search

mylesagray / homebridge-blueair

BlueAir air purifier plugin for homebridge
Apache License 2.0
39 stars 20 forks source link

Updated to Homebridge platform #47

Closed fjs21 closed 3 years ago

fjs21 commented 3 years ago

Hi @mylesagray,

As I was getting numerous warnings from Homebridge, I took a look at the blueair plugin to see if I could fix but then got a bit carried away.

I started working on a fork of your awesome plugin and recoded it using typescript as a dynamic platform type plugin. This way when you login, the BlueAir devices are detected and added as accessories automatically.

I also enabled configuration using the Homebridge UI so folks do not have to work with the json config directly. I also added some experimental code to allow people to hide devices that they do not want to wish to appear in Homebridge. This could also be extended to turn on/off support for features as you do.

https://github.com/fjs21/homebridge-blueair

mylesagray commented 3 years ago

Amazing work!

If you like, I can pull the changes into this repo and add you as a maintainer - rather than it living in a fork?

On 15 Nov 2021, at 14:08, Fraser Sim @.***> wrote:

Hi @mylesagray https://github.com/mylesagray,

As I was getting numerous warnings from Homebridge, I took a look at the blueair plugin to see if I could fix but then got a bit carried away.

I started working on a fork of your awesome plugin and recoded it using typescript as a dynamic platform type plugin. This way when you login, the BlueAir devices are detected and added as accessories automatically.

I also enabled configuration using the Homebridge UI so folks do not have to work with the json config directly. I also added some experimental code to allow people to hide devices that they do not want to wish to appear in Homebridge. This could also be extended to turn on/off support for features as you do.

https://github.com/fjs21/homebridge-blueair https://github.com/fjs21/homebridge-blueair — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mylesagray/homebridge-blueair/issues/47, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUYTEFU3B4ABTMTNLHRLLUMEH6ZANCNFSM5IBY454Q.

fjs21 commented 3 years ago

I'm not very experienced with this but I'm not sure that a pull is the best option as it will break a lot of people's setups. Mine was working basically fine up as long as it ran in a bridge.

If you don't mind I could respond to the issues of others to direct them to my fork as an alternative? Quick change of the readme file may also work to direct people to the platform fork?

mylesagray commented 3 years ago

Sure that works too, if you want to open a PR for a readme update, I’ll merge it.

On 15 Nov 2021, at 14:23, Fraser Sim @.***> wrote:

I'm not very experienced with this but I'm not sure that a pull is the best option as it will break a lot of people's setups. Mine was working basically fine up as long as it ran in a bridge.

If you don't mind I could respond to the issues of others to direct them to my fork as an alternative? Quick change of the readme file may also work to direct people to the platform fork?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mylesagray/homebridge-blueair/issues/47#issuecomment-968959967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUYTBCIHWXJ6QTMTEEHH3UMEJWRANCNFSM5IBY454Q.

fjs21 commented 3 years ago

I couldn't work out how to do the PR for just a single file and not blow up the entire repository.

You could either use my readme.md file or just put a link to my repo in your readme. Sorry for the extra hassle.

mylesagray commented 3 years ago

Added a redirection to your plugin Fraser, i'm considering archiving this repo if you are done addressing the issues from users and redirecting them to your plugin?

fjs21 commented 3 years ago

I’ll post a few more replies to the issues in your repo this am and you can go ahead at that point. This evening?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Myles Gray @.> Sent: Tuesday, November 16, 2021 5:06:41 AM To: mylesagray/homebridge-blueair @.> Cc: Fraser Sim @.>; Author @.> Subject: Re: [mylesagray/homebridge-blueair] Updated to Homebridge platform (Issue #47)

Added a redirection to your plugin Fraser, i'm considering archiving this repo if you are done addressing the issues from users and redirecting them to your plugin?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmylesagray%2Fhomebridge-blueair%2Fissues%2F47%23issuecomment-970114041&data=04%7C01%7C%7C19af0dd27b0f4ae65eaa08d9a8e8ca2f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637726540042987050%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vqUIF0frW4NITDRZO0I2XRt1mBIojr%2Bz3fTDsxLy7AY%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPVM4CY3SD727BV5Z5DFE7TUMIULDANCNFSM5IBY454Q&data=04%7C01%7C%7C19af0dd27b0f4ae65eaa08d9a8e8ca2f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637726540042996998%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JvVkTLE1K%2Bv5HyLX63alD903qsoZJJK37CLaT7DH4Ow%3D&reserved=0.

mylesagray commented 3 years ago

Sounds good to me!

On 16 Nov 2021, at 11:16, Fraser Sim @.***> wrote:

I’ll post a few more replies to the issues in your repo this am and you can go ahead at that point. This evening?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Myles Gray @.> Sent: Tuesday, November 16, 2021 5:06:41 AM To: mylesagray/homebridge-blueair @.> Cc: Fraser Sim @.>; Author @.> Subject: Re: [mylesagray/homebridge-blueair] Updated to Homebridge platform (Issue #47)

Added a redirection to your plugin Fraser, i'm considering archiving this repo if you are done addressing the issues from users and redirecting them to your plugin?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmylesagray%2Fhomebridge-blueair%2Fissues%2F47%23issuecomment-970114041&data=04%7C01%7C%7C19af0dd27b0f4ae65eaa08d9a8e8ca2f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637726540042987050%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vqUIF0frW4NITDRZO0I2XRt1mBIojr%2Bz3fTDsxLy7AY%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPVM4CY3SD727BV5Z5DFE7TUMIULDANCNFSM5IBY454Q&data=04%7C01%7C%7C19af0dd27b0f4ae65eaa08d9a8e8ca2f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637726540042996998%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JvVkTLE1K%2Bv5HyLX63alD903qsoZJJK37CLaT7DH4Ow%3D&reserved=0. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mylesagray/homebridge-blueair/issues/47#issuecomment-970170430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUYTAYSTWQ74OPKTA6DUDUMI4SLANCNFSM5IBY454Q.