search

mylesmmurphy / prettify-ts

Prettify TypeScript: Better Type Previews
https://marketplace.visualstudio.com/items?itemName=MylesMurphy.prettify-ts
MIT License
263 stars 8 forks source link

No longer seems to work with the latest Typescript (5.6.3) #42

Closed LoiLock closed 2 weeks ago

LoiLock commented 1 month ago

Following the example provided in the screenshot:

image image

In the past this worked without fail, and had been enjoying it for a long time

LoiLock commented 1 month ago

Downgrading to 0.019 Works for me, but I don't see that as a solution (especially as that version seems to be a lot slower)

I saw that you released 0.1.6, I installed that and something in there seems to have fixed it

mylesmmurphy commented 1 month ago

Hey @LoiLock Thanks for mentioning this. I'm unfortunately unable to reproduce this. I have tried using the published version (v0.1.5), with the most recent versions of TypeScript (5.6.3, 5.7.0-dev.20241010, 5.7.0-dev.20241011). Would you mind sharing your version of VSCode and TypeScript which you're running into this? 🙏

LoiLock commented 1 month ago

Vscode 1.94.1 and I'm using my workspace's Typescript binary, which is 5.6.3. It's strange, I noticed it a while ago but didn't initially do anything about it, I unfortunately can't share the project itself since it's for the company I work for, so creating a minimal reproduction would be difficult. I don't know if it's relevant that we use pnpm (which is also how typescript is installed in our project).

My node version is 22.8.0, installed using nvm.

I'm sorry that I can't be of any more help, 0.1.6 has been working beautifully for me, and it's easily my favorite extension!

mylesmmurphy commented 2 weeks ago

Hey @LoiLock! I'm going to close this for now, but please feel free to re-open if you run into the issue again. 😄