Enhancement: Add recipe for blacksmith/armourer scrap/glassblower

[GoogleCodeExporter]

The recipe is: at least 40% quality of combined item gives a 
blacksmith/armourer scrap/glassblower (from quality weapon/armor/flask 
respectively).

Adding the recipe would be helpful for managing quality items; it could even 
suggest the best combination for optimizing the usage of quality items (i.e. 
you have a 20%, 20%, 30% and 10%. The best output would be 20+20 and 30+10)

Original issue reported on code.google.com by michelem...@gmail.com on 31 Jul 2013 at 12:42

[GoogleCodeExporter]

These are recipes I use extensively (at least, the lower-level ones), so I took 
a stab at implementing it.  Attached is a patch that adds recipes for 
Armourer's Scrap, Blacksmith's Whetstone, Cartographer's Chisel, and 
Glassblower's Bauble.  The algorithm currently in place (for Gemcutter's Prism) 
prefers "perfect" combinations -- those totally exactly 40% quality -- and then 
those that go over 40% by the least amount, so I did not make any changes to 
the algorithm.

The changes are a little bit wide-spread, so I am also attaching more technical 
patch notes for the developers to review and more easily understand the changes.

Also, I noticed the latest revision in the source code repository still has the 
version at 0.0.8, so I can merge my changes with the actual latest version 
(0.0.9) of the repository after it is updated, if needed.

Original comment by cmaca...@gmail.com on 27 Oct 2013 at 6:03

Attachments:

• PatchNotes.txt
• QualityRecipesPatch.patch

[GoogleCodeExporter]

I'm blown away, I had somehow missed this, thanks very much for this quality 
(pun intended) contribution!

I agree with you completely on renaming Quality to Rarity, the class name is a 
remnant of when Procurement was still a console application. 

A note on adding map to GearType, GearType inherits from Item, and there is the 
ItemType map so you can just go:

items.OfType<Map>

Everything else looks great, I will be committing shortly and including your 
changes in 1.0.0 !

Original comment by stickymaddness on 16 Nov 2013 at 11:29

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Original comment by stickymaddness on 16 Nov 2013 at 11:43

• Changed state: Fixed

[GoogleCodeExporter]

You're welcome!  I'm glad I can be a part of this project.

Great point about the Map and GearType; your version is more elegant.

Original comment by cmaca...@gmail.com on 18 Nov 2013 at 1:11