mylinhthibodeau / STAT545-HW-thibodeau-mylinh

0 stars 0 forks source link

hw02 ready for grading #1

Open mylinhthibodeau opened 7 years ago

mylinhthibodeau commented 7 years ago

Dear @vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho,

You can find my homework 2 folders here.

Please note that as explained in my README file, there are two subfolders with the exact same information:

If you have any questions or would like clarifications, please do not hesitate to let me know !

Thank you for your time, Warm regards, My Linh Thibodeau

mylinhthibodeau commented 7 years ago

Dear @vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho @jenncscampbell and @bcahn7,

Please note that I am still very confused with my git repositories organization (I know it is suppose to be basic stuff, so I am so sorry) so I accidentally modified my homework 2 because I was trying to create a duplicate of the homework and to have an "improved" version tracking also the things I have learned from reviewing other people's homework and in class.

Update: the mistake has been corrected !! Sorry again for this !

Warm regards, My Linh

Jenncscampbell commented 7 years ago

Thank you so much for this message. I first went your repo on Friday and couldn’t find your assignment so I’m very glad you added me in this issue :smiley:

I appreciate that you tried to make your files easier to find by linking in the readme. I still found it a bit difficult since I really just wanted one readme and one gapminder.md file. I was a bit unclear on why you had a brief narrative here. It seemed like a list of our assignment, I’m not sure you needed it here.

I see from your readme that your arrange function wasn’t working. It seems like it did work for some of your tables though (like your minimum life expectancy table). It does seem to default to ascending. Maybe you fixed this after you posed this comment but it does seem to work okay now.

I also found there were a lot of hidden plot functions. Stackoverflow is great for this.

I really liked your life expectancy stacked chart as a ggplot function. I’m not sure it was appropriate for this data since it is hard to see change across Africa and Americas this way your boxplot one makes it much easier to interpret the data. Thank you for showing me both types though!

You obviously learned how to use the mutate, filter and group by functions. It would have been nice to see a plot for some of these. I see that you had a note for a plot for your my_europe data set but this doesn’t appear in your .md file

Good job! Thanks for created and showing me so many different graph types. It really is overwhelming how many there are.

mylinhthibodeau commented 7 years ago

Dear @Jenncscampbel,

When I am added to the repository of somebody else, Github automatically notify me that I have been invited as a collaborator.

I added you as a collaborator last week, but I didn't know that you hadn't received a collaboration invite, so it's good to know for the future ! I will always tag the reviewers-students in my next homework assignments :)

Just as a side note, the arrange function issue was experienced with research published genomic data, not with Gapminder ! If you are curious, you can go to my unfinished hw03 here and look at the plot labelled "p5" to see a bunch of rainbow-coloured confetti data points, then take a look at the plot under it to see it when the factor variable has been arranged appropriately !

Thank you so much for your time and your review, I greatly appreciate it !!

Warm regards, My Linh

bcahn7 commented 7 years ago

Hello @mylinhthibodeau ,

Here are some comments on your hw02. Hope it helps!

Overall, I think you did a great job and showed all the things expected to be done in the homework 02 (Even more!). I've learned a lot from your assignment. I appreciate it. Hope you can apply your knowledge to genomic data analyses! Well done!

pgonzaleze commented 7 years ago

Hi @mylinhthibodeau here are some comments about your assignment:

Smell test of data: Yes Explore at least one categorical/quantitative variable: Yes Uses various ggplot types: Yes Uses filter(), select(), and %>%: Yes Reflection on process: Yes

Hi My Linh, great job! I appreciate that you explained details about the organization of your documents especially if you are struggling with it. In terms of your homework/code, I also found useful that you gave comments before each line in order to know what you are doing and what you realized, great! Your exploration is really good, you gave different way to tackle questions/issues. You not only tried several plots but also gave a rationale of use them and provided nice data (for general knowledge, eg. Rwanda genocide). I think that you have gained good experience, I have to say that sometimes it is difficult to find the utility of something using different data because one can only think on his/her area of expertise, I am looking forward to see how you are going to implement this new learned tools in your genomic area! Well done!

Your marks will be distributed later! Regards