mylinhthibodeau / STAT545-HW-thibodeau-mylinh

0 stars 0 forks source link

hw04 ready for grading #4

Open mylinhthibodeau opened 7 years ago

mylinhthibodeau commented 7 years ago

Dear @abishekarun and @Tangjiahui26,

I unfortunately didn't realize that we only needed to pick two activities in total, and that's why my original Homework 4 (now entitled "long-version-stat545-hw04-thibodeau-mylinh") file is NOT THE ONE TO REVIEW.

For the MARKING/PEER REVIEW FILES, you can limit yourself to the README file HERE and these two cheatsheets:

The general homework 4 repository is here

Thank you for your time, and if you have any questions, please don't hesitate to let me know, Warm regards My Linh

Tangjiahui26 commented 7 years ago

Peer Review:

Hi, My Linh! As you explained, I looked mainly at activity5 in the data reshaping part and activity2 in the join part. In fact, I also looked at your long version homework roughly. I think you did a really well job to explore your own dataset and it is cool to take advantage of what you have learned in class to solve your research problems.

Overall, it looks like you have put significant time and effort into this assignment. Great work!

Regards, Jiahui Tang

mylinhthibodeau commented 7 years ago

Dear @Tangjiahui26,

Thank you so much for your feedback, I greatly appreciate it !

I found myself having trouble with the RMarkdown formatting: I type 2 empty spaces after the end of a line to make sure that RMarkdown will understand that it needs to skip a line. When I used knitr on my personal computer, the formatting was perfect, as you can see HERE, but when I pushed the file to github, somehow, the spaces were lost, the titles scrammed together and the formatting messed up!

Never mind I found it!! I had to change "options(knitr.table.format = "html")" to this below in order for the RMarkdown formating to function properly !!

options(knitr.table.format = "markdown")

Thank you for your time, Warm regards My linh

abishekarun commented 7 years ago

Peer Review:

Hi, @mylinhthibodeau ! You did an excellent homework and went above and beyond the requirements of the assignment. In fact, you only need to pick one of the data reshaping prompt and a join prompt, but you have gone ahead by doing all the activities/prompts, which is worthy of praise. It was also very apt to see you use datasets pertaining to your research work and this motivates people like me.

Data manipulations in R

Data joining

I also checked your long version and it shows the kind of effort that you had put into this assignment. You had explored lot more than that was asked.

Some suggestions

It was great to see that you had put the links for the files in the issue as it makes easy to access the file. The fact that you had mentioned the struggles that you had experienced and the solutions that you followed is very helpful and useful for other students.It was also nice to see you mention the new things that you learned through this assignment in a clear and elaborate manner. I hope to follow this for upcoming assignments.Thanks for that.

Overall, I think your homework was really well done and hope you can keep it up!

Regards, Arun Rajendran

pgonzaleze commented 7 years ago

Hi @mylinhthibodeau here are some comments about your homework General data reshaping and relationship to aggregation: Yes Join, merge, look up: Yes Progress report: Yes Extras (optional; merge/match): Yes

Part 1

Part 2

Your marks will be distributed later,

Regards,

Pedro G