mylinuxforwork / dotfiles

The ML4W Dotfiles for Hyprland - An advanced and full-featured configuration for the dynamic tiling window manager Hyprland including an easy to use installation script for Arch based Linux distributions.
GNU General Public License v3.0
1.16k stars 89 forks source link

[BUG] Running ml4w-hyprland-setup after update does not respect previous configs #440

Closed mgeldi closed 3 hours ago

mgeldi commented 1 week ago

Describe the bug When I run the setup after an update, I always end up with my own changes not being copied over to the "updated" dot files. E.g. my main important changes which I always have a problem with:

I always end up needing to redo this. I remember though that it did ask me to create a backup and then also copy over from that backup - I clearly remember having selected all the files, but they weren't copied over - e.g. I'm left with a broken monitor setup.

To Reproduce Steps to reproduce the behavior:

  1. With own changes of dotfiles, run a ml4w-hyprland-setup after update
  2. Hit yes on backup, select all files to be backed up and confirm
  3. After update, monitors immediately flicker, indicating the monitors/default.conf was overwritten by the defaults of ml4w - in fact, not a single one of my own conflicting dotfiles is untouched.

Expected behavior I run an update, I hit create backup, I select which files to copy over from the backup. Then ideally I run a merge on two conflicting ones if there's some sort of new hyprland requirements to fix them up. Once I'm done running the script, I should have the latest changes of upstream without having messed up my own dotfiles.

Screenshots Not needed

Distribution (please complete the following information):

Additional context I was thinking if this is even a bug or not, but the way the script presents the options to backup and then copy over the existing ones to the new dotfiles does suggest that it should work like this.

mylinuxforwork commented 1 week ago

Thanks for testing. I will check.

Neo-29 commented 1 week ago

Confirmed

mylinuxforwork commented 6 days ago

I will test with the upcoming 2.9.7 when I update from 2.9.6.7.

SketchyStunts commented 5 days ago

Happened to me as well updating this morning

mylinuxforwork commented 3 hours ago

@SketchyStunts Solved with 2.9.7.0RC1