mym0404 / react-native-kakao

🟡 Kakao SDK All-In-One Solution Supports Android, iOS, Web, New architecture, Old Architecture, Expo
https://rnkakao.dev
MIT License
36 stars 0 forks source link

fix: remove unused deps `RNCKakaoUser` in social #34

Closed lifeisegg123 closed 6 days ago

lifeisegg123 commented 6 days ago

Type of change

What does this change?

Remove the unused dependency RNCKakaoUser in the social package, which causes an error during pod install.

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **react-native-kakao** | ⬜️ Ignored ([Inspect](https://vercel.com/mj-studios-projects/react-native-kakao/BhP36srRhki24fyTuR4QgitKmDSX)) | [Visit Preview](https://react-native-kakao-git-fork-lifeiseg-0a1839-mj-studios-projects.vercel.app) | | Jun 24, 2024 6:44am |
mym0404 commented 6 days ago

what error? you should add user package if want to use social. it is described in docs.

Also, you should open related issue first for PR.

lifeisegg123 commented 6 days ago

@mym0404 I'm trying to use share package, and it is not documented in here.

mym0404 commented 6 days ago

ok we should change share package's installation docs instead.

lifeisegg123 commented 6 days ago

I've got a question. In the share package, the only part of use something relative to social is here. However, it doesn't seem to be part of social but rather of core. Therefore, I think that social can be removed from the dependencies of share. What do you think? If my understanding of your library is incorrect, please let me know.

mym0404 commented 6 days ago

social depends on talk native sdk and RNCKakaoShareModule depends on talk so talk is a transitivity dependency. In the monorepo design, I thought we had to prevent two RN package depends on same kakao native sdk.

mym0404 commented 6 days ago

code you indicated is unrelated to social package, yes

lifeisegg123 commented 6 days ago

thanks 👍