mymarilyn / clickhouse-driver

ClickHouse Python Driver with native interface support
https://clickhouse-driver.readthedocs.io
Other
1.2k stars 214 forks source link

fix `client.insert_dataframe()` for tuple columns in tables #425

Closed stankudrow closed 6 months ago

stankudrow commented 6 months ago

Notes:

The list of selected packages from the virtual environment:

Checklist:

xzkostyan commented 6 months ago

Ensure PR doesn't contain untouched code reformatting: spaces, etc. -> the changed modules have been passed multiple times through the black and ruff packages;

Black or ruff linters should be added in different PR. I don't see any profit from passing code through these linters without any validation in actions.

Drifting towards the f-string formatting seems important, but in this PR it is done partially.

This also should be done in different PR.

This PR should contain only minor changes about insert_dataframe.

stankudrow commented 6 months ago

Fair enough, easier or cheaper to close this PR in favour of #426.