Closed stankudrow closed 6 months ago
Ensure PR doesn't contain untouched code reformatting: spaces, etc. -> the changed modules have been passed multiple times through the black and ruff packages;
Black or ruff linters should be added in different PR. I don't see any profit from passing code through these linters without any validation in actions.
Drifting towards the f-string formatting seems important, but in this PR it is done partially.
This also should be done in different PR.
This PR should contain only minor changes about insert_dataframe
.
Fair enough, easier or cheaper to close this PR in favour of #426.
Notes:
This PR
To do:
setup.py
support in favour of thepyproject.toml
file (a historical document is PEP-621) and modern packaging and dependency managers like hatch, poetry, pdm and so forth. I am willing to do this work in one of the next PRs.The list of selected packages from the virtual environment:
pytest.mark.parametrize
)Checklist:
flake8
and fix issues -> issues fixed, after moving to thepyproject.toml
support the linters and any other code-quality packages (a good idea is to adopt the black+mypy+ruff as a dev-qa core) will be tuned in a more explicit way;pytest
no tests failed. See the dev docs -> a test case within the pandas related test suite has been added.