mymikemiller / a-simple-lastfm-scrobbler

Automatically exported from code.google.com/p/a-simple-lastfm-scrobbler
GNU General Public License v3.0
0 stars 0 forks source link

Does not support usernames with spaces #54

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create an account on Libre.fm with spaces in the username (mine, for 
instance, is "Mind Booster Noori")
2. Try to log in Libre.fm with that username
3. It will say "wrong username or password". The field shows that the spaces 
were taken off

What is the expected output? What do you see instead?

I expected to be logged in.

What version of the product are you using? On what operating system?

Latest version on the market, running on Android 1.6.

Original issue reported on code.google.com by mindboos...@gmail.com on 30 Jun 2010 at 2:22

GoogleCodeExporter commented 9 years ago
I would guess that the culprit is this line:
            username = username.replaceAll("\\s", "");
and that we can safely comment it, but I would like to know first why is it 
there...

Original comment by mindboos...@gmail.com on 30 Jun 2010 at 3:23

GoogleCodeExporter commented 9 years ago
Yep, that's probably it. I don't know why I added that line to begin with, 
although I didn't know that Libre.fm allows usernames with spaces. I'm pretty 
sure Last.fm doesn't. But that's beside the point. I'll post a quick update you 
can test soon.

Original comment by tgwizard on 30 Jun 2010 at 5:31

GoogleCodeExporter commented 9 years ago
Can you test this apk: 
http://a-simple-lastfm-scrobbler.googlecode.com/files/a_simple_lastfm_scrobbler_
1.3.apk

I haven't released it on the Market yet, I'll do it after the testing.

Original comment by tgwizard on 30 Jun 2010 at 5:44

GoogleCodeExporter commented 9 years ago
Nope, it is still taking the spaces out... Just to explain better, I see that 
the spaces are not there because after it says "Wrong username/password", if I 
click again on "User credentials" the username that appears on the username 
field is "MindBoosterNoori" and not "Mind Booster Noori".

Original comment by mindboos...@gmail.com on 30 Jun 2010 at 5:59

GoogleCodeExporter commented 9 years ago
Hmm... I'll look into it

Original comment by tgwizard on 30 Jun 2010 at 6:09

GoogleCodeExporter commented 9 years ago
Hey, Libre.fm doesn't support usernames with spaces in them!? Something is 
wrong here...

Original comment by tgwizard on 4 Jul 2010 at 12:04

GoogleCodeExporter commented 9 years ago
It sure does, check here my profile for an example: 
http://alpha.libre.fm/user/Mind+Booster+Noori (replace "+" with a space or 
"%20" if you want...)

Original comment by mindboos...@gmail.com on 4 Jul 2010 at 12:28

GoogleCodeExporter commented 9 years ago
Possibly helpful, lastfmsubmitd also works properly with libre.fm, here's a 
submission it did today with my account:

2010-07-03 22:46:31,713 lastfmsubmitd[2112] DEBUG: POST data: 
s=bfd8c18411a245f27d6015f24abdf9cd&u=mind+booster+noori&i%5B0%5D=2010-07-03+21%3
A46%3A28&b%5B0%5D=&a%5B0%5D=&m%5B0%5D=&t%5B0%5D=&l%5B0%5D=860

Original comment by mindboos...@gmail.com on 4 Jul 2010 at 12:29

GoogleCodeExporter commented 9 years ago
When I try to register a new user with spaces in the username I get the 
following error:

Your username must be at least 3 characters in length (max 16) and only consist 
of a-z, A-Z, 0-9 and _ (underscore), and may not begin or end with an 
underscore.

But it SLS (in v1.3.1) doesn't remove the spaces when I try to log into an 
non-existent account (it just fails). I even tried logging in as "Mind Booster 
Noori" (with bogus password). And it just fails, without removing the spaces. 
Could you try installing v1.3.1 again?

Original comment by tgwizard on 4 Jul 2010 at 12:36

GoogleCodeExporter commented 9 years ago
Oh, it might be that Libre.fm used to support spaces in usernames, but don't do 
it for new accounts.

Original comment by tgwizard on 4 Jul 2010 at 12:37

GoogleCodeExporter commented 9 years ago
Yes, that's possible. Retried 1.3.1, still with the same problem.

Original comment by mindboos...@gmail.com on 4 Jul 2010 at 12:47