mymikemiller / a-simple-lastfm-scrobbler

Automatically exported from code.google.com/p/a-simple-lastfm-scrobbler
GNU General Public License v3.0
0 stars 0 forks source link

Cache scrobbles even if no account is configured/logged in #93

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently the code simply ignores tracks if no account has been configured yet.

I wrote a little patch to fix this.
Tracks are now cached, but not sent to the services (Last.FM etc.).

I could think of more nice things regarding cache handling, but they're just 
"nice to have":
- Add an option to clear the cached scrobbles
- Don't delete cached scrobbles when deleting account settings

Original issue reported on code.google.com by darkligh...@googlemail.com on 17 Jun 2011 at 1:58

Attachments:

GoogleCodeExporter commented 9 years ago
From what I can read without testing myself, this won't really work. 
ScrobblingService.queue() will add the track to the db, but it won't be 
associated with any "NetApp", so it will never be scrobbled. 

Or am I wrong?

Also, I'm not sure I wan't SLS to do this. What if you just install SLS and 
don't configure an account - this will make all tracks played still get into 
the cache, taking up (admittedly small) space. 

(Clearing the cache is already an option.)

Original comment by tgwizard on 18 Jun 2011 at 6:01

GoogleCodeExporter commented 9 years ago
Oh yes, you are right.
Looks like I only tested it after I gave your app my account details.

You can close this issue if you want.

Original comment by darkligh...@googlemail.com on 18 Jun 2011 at 6:11

GoogleCodeExporter commented 9 years ago

Original comment by tgwizard on 18 Jun 2011 at 6:13