Closed kofigumbs closed 2 years ago
I confirm this fixes the problem for me as well. Thanks! Using your fork in the meantime...
I apologize for missing this, I've been very busy. It does seem that update
is the correct way to go. I'll release a new version with updated docs. I'll have the old update-tags
configuration act as a fallback if update
is not defined for compatibility.
I confirm this fixes the problem for me as well. Thanks! Using your fork in the meantime...
Please be aware that @kofigumbs 's fork has not updated dist/index.js, meaning that his changes are not actually being executed when using the action.
Thanks for the quick turn around!
Please be aware that @kofigumbs 's fork has not updated dist/index.js, meaning that his changes are not actually being executed when using the action.
Oh, strange that it worked then. I'll switch back to your repo to be on the safe side, thank you for the warning.
No problem. A tag for v11 has been created.
I encountered the following error in my action whenever I set an explicit version:
My workflow config
Changing
emsdk update-tag
toemsdk update
fixed it for me, but I'm not 100% sure if that's the right solution. It does seem likeupdate-tags
is effectively gone though: https://github.com/emscripten-core/emsdk/pull/738.If this switch to
update
is the way you want to go, I'd be happy to do the work to get this PR merge-ready. I only had to change the implementation to workaround the issue, but I imagine we'd at least want to update the docs too. One open question is whether changing the name in the action input would cause any compatibility concerns.