search

mymonero / mymonero-app-ios

The MyMonero native iOS app
BSD 3-Clause "New" or "Revised" License
51 stars 18 forks source link

Ability to display scanning indicator at same time as Import Transactions button necessary? #27

Open paulshapiro opened 6 years ago

paulshapiro commented 6 years ago

Not sure if necessary.

In the JS app, which is implemented to the original Sketch design of the desktop app, the Import Transactions button is displayed within the no transactions empty state view on WalletDetails. In the iOS app, a section header view is used to display the Scanning blocks indicator atop the transactions section. This same header view is used in the iOS app to also show the import transactions button when necessary. Ordinarily the two options never need to be shown at the same time. To show them at the same time in the iOS app, I would either move the Import Transactions button down to the no transactions empty state table cell view, or make the section header view able to have a dynamic height and show the two subviews stacked on top of each other vertically when necessary.

paulshapiro commented 6 years ago

So this may end up being necessary if we want to use the "Scanning…" activity indicator to show on the Wallet Details page when the app is fetching updates for that wallet. This has been written for the JS app but remains commented.