mymonero / mymonero-app-ios

The MyMonero native iOS app
BSD 3-Clause "New" or "Revised" License
51 stars 18 forks source link

Re-enable landscape support for Phones in iOS 11 #37

Open paulshapiro opened 7 years ago

paulshapiro commented 7 years ago

It had to be disabled (temporarily?) because landscape gets clipped on the bottom of non-x, non-plus screens in ios 11 - appears landscape tab bar is too big - not due to app code change, happened on update - investigated new ios 11 SDK support but ran into issues - we reasoned that landscape wasn't critical for iPhone (despite it being desirable for plus and x screens) - left branch https://github.com/mymonero/mymonero-app-ios/tree/WIP_ios11_nonplusnonx_landscape

Also note that if landscape support is re-enabled, we will also need to fix the Emoji picker Popover's bug / lack of support for safeAreaInsets or the popover will underlap the sensor area.

Also note: might also need to revert and solve the problem behind the .never scroll update changes of https://github.com/mymonero/mymonero-app-ios/commit/02f20e874662967eb059fad5c85b34a943e7e166