On the 'Send Monero' screen capturing a QR code, resets the other form fields if they have been changed - Githubissues

mymonero / mymonero-app-ios

The MyMonero native iOS app

BSD 3-Clause "New" or "Revised" License

51 stars 18 forks source link

On the 'Send Monero' screen capturing a QR code, resets the other form fields if they have been changed #78

Open tficharmers opened 5 years ago

tficharmers commented 5 years ago

To reproduce:

navigate to 'Send Monero' screen
enter an amount
change the currency selection
generate a PID
change the Transfer priority from Low

Then 'Use Camera' and capture an address from a QR code and the address is populated on the page, but all the other fields have reset to default.

The same happens when you use a QR code through 'Choose file'.

I don't think this is a desirable UX.

paulshapiro commented 5 years ago

Gotcha. If the fields arent represented in the QR URI then they shouldnt change the form field values.

paulshapiro commented 5 years ago

Ok so I totally agree on the priority and amount. And address/contact is bound to change. But I'm not sold on currency. Reason is that a request is explicitly denominated in Monero unless otherwise specified. I think not updating the ccy to Monero by default if ccy not in uri could lead to mistakes.

tficharmers commented 5 years ago

Interesting. So I experienced this when I was doing some testing and added 0.1 in the amount and changed the currency to GBP, then, I guess because it is in the flow down the page, found the 'Use Camera' button, captured the QR code and returned to have to fill in the fields again. The other fields (priority and PID) I just noticed when doing some more testing.

I agree with you on things having to be cleared based on the information in the QR code, but I can envisage other people filling in fields, then capturing a QR code using the bottom two buttons and then have to refill the fields again. Perhaps it is an issue that the QR capture buttons are at the bottom of the page? Having said that, I've never experienced this before, because I presume that I have just gone for the 'Use Camera' button straight away and then filled in the other fields. But then I have been using/testing this app for a while now so my understanding of the app is different compared to new users.

Would a concern with resetting the currency dropdown but not the amount, be that someone might fill in 1GBP and might end up sending 1XMR if they haven't noticed that it's switched back?

paulshapiro commented 5 years ago

Exactly

tficharmers commented 5 years ago

Ok. So I agree now that the resetting behaviour is a safer thing to do. I am still thinking about the UX implications of filling out the fields and then at the bottom using one of the buttons to capture a QR code. Just off the top of my head, the first suggestion could be to make the 'Address' the first field on the page and have the QR capture buttons underneath that field, instead of at the bottom of the page. People filling in the form from top to bottom should then avoid the form resetting. Just a thought.

paulshapiro commented 5 years ago

I've modified it so that the form won't clear but it will preserve the payment id, amount, etc (but not currency) unless those are present in the request.

paulshapiro commented 5 years ago

How about trying it in 1.1.8 and seeing how it feels?

tficharmers commented 5 years ago

Yeah, will do.