search

mymonero / mymonero-app-ios

The MyMonero native iOS app
BSD 3-Clause "New" or "Revised" License
51 stars 18 forks source link

App crashes with self-hosted API #90

Closed dzonatan closed 3 years ago

dzonatan commented 3 years ago

The application crashes when using with a self-hosted api (monero-lws in my case). Strangely, this happens ONLY when wallet has some balance in it.
There are no issues with freshly (0 balance) created wallets.

iOS v14.4

dzonatan commented 3 years ago

After some debugging I've found that monero-lws uses slightly different timestamp format that cannot be parsed by mymonero-ios which leads to this crash. However, I'm not sure which side should have to change the format as both uses different variation than specified in lightwallet API. I think I'll have to raise this question on meta project as the specification itself is a bit too vague and needs a better explanation.

Still, I think this needs to be handled in a better way, e.g. tell the user that server didn't respond with correct data or something like that... so I'll keep this issue open.

devinpearson commented 3 years ago

Hi @dzonatan, monero-lws has updated their dates to match the mymonero app , can you confirm if this is still an issue?

dzonatan commented 3 years ago

Yes - it's working as expected now. Although, I still think that the error handler could be improved in case something similar breaks in the future. But feel free to close it.

devinpearson commented 3 years ago

Definitely agree with the need for better error handling for it. I will be creating an enhancement issue in our desktop repo which will be extended to the ios and Android app