mymonero / mymonero-app-js

The JS codebase for the MyMonero desktop apps
BSD 3-Clause "New" or "Revised" License
528 stars 154 forks source link

ARM64 #349

Open joshbowyer opened 3 years ago

joshbowyer commented 3 years ago

Could MyMonero be packaged for arm64 as either a .appimage or a flatpak? This may be especially useful with the recent introduction of the Pinephone/Librem5 as Linux phones

devinpearson commented 3 years ago

Will chat with the team and look at the options.

ChiefMateStarbuck commented 3 years ago

It would also be helpful for the new Apple silicon (m1).

devinpearson commented 3 years ago

@ChiefMateStarbuck we run into a bit of a limitation with electron when it comes to supporting the m1 chip. with it requiring an upgrade to a version of electron that currently doesn't work with the codebase. I have considered making the iOS app available to the m1 as the app store now allows ios apps to be on the macs. it would require some testing though

jla3378 commented 2 years ago

Any updates on getting Electron to at least version 11? (aka the minimum target to build for arm64-darwin) @devinpearson

I tried building the develop branch just now by manually forcing version 11 and the app compiles but is not functional upon launch:

An unexpected application error occurred.

Please let us know of the following error message as it could be a bug:

 <p><span style='font-size: 11px;'>TypeError: Cannot read property 'app' of undefined</span></p>TypeError: Cannot read property 'app' of undefined
    at file:///Applications/MyMonero.app/Contents/Resources/app.asar/local_modules/MainWindow/Views/index.electron.renderer.js:37:38Mozilla/5.0 (Macintosh; Intel Mac OS X 12_0_1) AppleWebKit/537.36 (KHTML, like Gecko) MyMonero/1.2.2 Chrome/87.0.4280.141 Electron/11.5.0 Safari/537.36
jla3378 commented 2 years ago

So far, only the official monerod and other supporting binaries are arm64 compatible with no issues. There is no Monero wallet with a GUI that runs on arm64-darwin and building the open sourced ones including this ends in varying degrees of failure.