search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

Create tx with pre-generated txkey #49

Closed marceloneil closed 6 years ago

marceloneil commented 6 years ago

Since the tx private key is irrecoverable, I think it makes sense to provide some method of storing it. This PR adds an optional parameter to the create_transaction() and construct_tx() functions called txkey, so that you can generate and save the txkey, and use it to generate a transaction.

I'm unsure about how the branches work on this repo, so let me know if it's better to do a PR against develop

48 against the develop branch

paulshapiro commented 6 years ago

Do I gather from this that you're not using SendFunds, yourself? (Just wondering why not to return txKey through SendFunds as proposed)

marceloneil commented 6 years ago

Oh my bad - I haven't actually used either yet, although I've relied on cryptonote_utils so far

paulshapiro commented 6 years ago

Though, since I'm about to merge my cpp branch anyway, and I'm returning tx key there (pushing soon), how about we hold off on merging this so as not to necessitate a rebase?

paulshapiro commented 6 years ago

@marceloneil fyi this is available now in the cpp branch