search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

Remove JS impl of `fixedMixin()` - has obstacle #53

Closed paulshapiro closed 6 years ago

paulshapiro commented 6 years ago

Remove JS fixedMixin() / find a way to move new_xmr_estFeeAmount's call to EstimatedTransaction_networkFee over to monero_utils implementation (it already encapsulates the fixed ringsize.. which we will then be able to remove from JS) - problem is that we must currently wait for asynchronous load of wasm module, but estimatefee is called earlier (it is called in SendFundsView_Base's init) and races - there might be other calls that we want to do w/o waiting

paulshapiro commented 6 years ago

So EstimatedTransaction_networkFee is now removed given the promises work on monero_utils causing mymonero-app-js to put monero_utils on the app context (no more load race condition), but I'm using fixedMixin for the JS impl of SendFunds and dont want to call to wasm just for that, since we're going to implement SendFunds in C++ anyway… so closing this for now