search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

NPM package #57

Open p0o opened 5 years ago

p0o commented 5 years ago

Is it possible to have an NPM package published for this repository? Preferably with a babel build script to publish the ES5 code so it wouldn't be rejected by React build environments.

paulshapiro commented 5 years ago

You can already install it over npm by specifying the git repo as there's a package.json and index.

I would generally be fine with the npm registry listing this repo but just be aware that you run a security risk by having that layer of automation... something I would tend to try to avoid recommending for such a sensitive library.

p0o commented 5 years ago

Yes, you are right about installing git repo using NPM, however, the master branch is not ES5 friendly (needs a bable build with a dist folder) and I'm not sure if cpp branch is production ready?

paulshapiro commented 5 years ago

The master branch has been built to es5 successfully by many people…

Cpp is close to or at production readiness. More people should test it.

paulshapiro commented 5 years ago

What would be done to the cpp branch which could not be done to the master branch anyway? I would accept a working PR .

p0o commented 5 years ago

The master branch has been built to es5 successfully by many people…

Yes I also put it in my webpack build but it's adding extra time to my environment build time and many standard webpack builds would ignore node_modules folder for build. It's common for JS dependencies to include a dist folder for prebuilt files to avoid these kind of issues.

paulshapiro commented 5 years ago

Feel free to submit fixes via PR. This is a community project :)

p0o commented 5 years ago

Sure, will submit soon