mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

Module not found: Error: Can't resolve 'electron' in mymonero-core-js/monero_utils #65

Closed imerkle closed 5 years ago

imerkle commented 5 years ago

I'm trying to use it in a browser web app not electron.

paulshapiro commented 5 years ago

In order to use the raw source code found in this repo, you generally want to package it up (unless you're cherry-picking which module you want to use). This project includes a script and example config file, which can be optimized for your specific needs.

As is under discussion in https://github.com/mymonero/mymonero-core-js/pull/63, it may even become a requirement that those who want to use the code in a browser compile the JS down to pre ES7 syntax.

Ok to close this?

paulshapiro commented 5 years ago

https://github.com/mymonero/mymonero-core-js/blob/master/bin/package_browser_js

paulshapiro commented 5 years ago

Should be resolved now that we no longer reference electron in this repo