search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

Added estimate_rct_tx_size #73

Closed gutenye closed 5 years ago

gutenye commented 5 years ago

Depends on https://github.com/mymonero/mymonero-core-cpp/pull/12

paulshapiro commented 5 years ago

Hey @gutenye, could I trouble you to rebase?

gutenye commented 5 years ago

@paulshapiro rebased

paulshapiro commented 5 years ago

Would be worthwhile to add this method back to the readme now that I've removed it but I can handle that. Thanks for the PR!!

paulshapiro commented 5 years ago

@gutenye you're missing the estimate_rct_tx_size implementation from serial_bridge ...

paulshapiro commented 5 years ago

(Scratch my previous comment of course - Guten corrected me as I was looking on master and had neglected to merge develop)