search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

Added encrypt_payment_id #82

Closed gutenye closed 5 years ago

gutenye commented 5 years ago

It can encrypt and decrypt payment_id

cpp PR is https://github.com/mymonero/mymonero-core-cpp/pull/21

paulshapiro commented 5 years ago

@gutenye i got an error while running the tests:

Exception while loading module: TypeError: Module.encrypt_payment_id is not a function
    at tests ([…]/tests/MyMoneroCoreCpp.node.js:267:29)
    at […]/tests/MyMoneroCoreCpp.node.js:277:2
paulshapiro commented 5 years ago

I gotta get into the habit of checking out the source branch and testing before merging

paulshapiro commented 5 years ago

Oh you know what, I didn't rebuild

paulshapiro commented 5 years ago

Ok looks good

gutenye commented 5 years ago

Yep, because of the inconsistent build, it's better that you build it.