search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

Fix encrypt_payment_id typo #83

Closed gutenye closed 5 years ago

gutenye commented 5 years ago

My mistake.

paulshapiro commented 5 years ago

Hm I'm curious, why did it appear to work before? Empty string or something received on cpp side in bridge? I'd have to check the cpp code.

gutenye commented 5 years ago

It didn’t work before. The tests only test Module.encrypt_payment_id method, not monero_utils.encrypt_payment_id

On Tue, Jan 8, 2019 at 6:54 PM Paul Shapiro notifications@github.com wrote:

Hm I'm curious, why did it appear to work before? Empty string or something received on cpp side in bridge? I'd have to check the cpp code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mymonero/mymonero-core-js/pull/83#issuecomment-452257688, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXCyBX1g4gPc1lyscwnfVLhlJuP7rGdks5vBHj1gaJpZM4Z1Az6 .

-- JavaScript, Go, Linux and Open Source https://www.guten.me

paulshapiro commented 5 years ago

Gotcha. thanks @gutenye