search

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps
BSD 3-Clause "New" or "Revised" License
101 stars 103 forks source link

method `create_signed_transaction` has been removed? #89

Closed i-xiaov closed 5 years ago

i-xiaov commented 5 years ago

I don't think that async__send_funds is more convenient than create_signed_transaction for developers. Is it possible to bring it back?

paulshapiro commented 5 years ago

The step1, step2 methods still exist. They can be bridged again easily enough if you want by undoing the commit that removed the bridging. But it's basically a community decision as to whether they want to bloat the build with it at this point.

paulshapiro commented 5 years ago

By the way you'd have to implement the retry routine plus all the parsing calls plus the networking calls and callbacks yourself again. I wouldn't like to duplicate those in this codebase again as we moved them to C++ so that they can be shared by all applications which actually need them.

I should ask: what problem makes you say it's not as convenient? the api remains basically the same for you..?

i-xiaov commented 5 years ago

I'm doing some offline-sign work. All UTXOs are managed by myself, so I prefer create_signed_transaction which create a signed transaction directly when i passed all data it needed rather than through many callbacks. I changed my code, it is compatible with async__send_funds now and it works well. So it's not a big deal. Thanks for your reply. I really appreciate your work.