Add estimate_fee and estimate_tx_weight

mymonero / mymonero-core-js

The JS library containing the Monero crypto plus lightwallet functions behind the official MyMonero apps

BSD 3-Clause "New" or "Revised" License

101 stars 103 forks source link

Add estimate_fee and estimate_tx_weight #91

Closed gutenye closed 5 years ago

gutenye commented 5 years ago

Read more at mymonero-core-cpp PR

I use object-style way to pass the arguments in.

Don't forget to update the mymonero-core-cpp submodule after this is merged :)

paulshapiro commented 5 years ago

Hey can you add simple tests for these to tests/monero_utils.spec.js? We can just compare to fixed expected output vals.

gutenye commented 5 years ago

Added, I also removed them from tests/MyMoneroCoreCpp.node.js unless you still want them there?

paulshapiro commented 5 years ago

It's nice to have the tests in MyMoneroCoreCpp as well since that tests the Module directly (i.e. as a unit test), but it's not necessary... the monero_utils test acts as a lightweight-enough integration test.