search

mymth / vanillajs-datepicker

A vanilla JavaScript remake of bootstrap-datepicker for Bulma and other CSS frameworks
MIT License
719 stars 147 forks source link

Problem with classes in datepicker button with Bootstrap 5 #188

Open DigitalAndSEO opened 3 days ago

DigitalAndSEO commented 3 days ago

Hi team, First of all, congratulations on the work! I wanted to tell you that I have been able to verify that when a button is used to open the datepicker, when the div is generated with classes "datepicker datepicker-dropdown datepicker-orient-left datepicker-orient-bottom" the upper buttons do not have the btn class, which makes it look like this:

Captura de pantalla 2024-06-27 a las 21 27 34 Captura de pantalla 2024-06-27 a las 21 28 09

If I add the "btn" class in the code inspector, it is perfectly integrated:

Captura de pantalla 2024-06-27 a las 21 28 52 Captura de pantalla 2024-06-27 a las 21 28 42

More than anything so that you can check it and if it is an error, add it in a new version. Right now I am adding it myself via JS, but I think it would be good for the project to have this added natively.

mymth commented 1 day ago

If you haven't, please read No. 1 of https://mymth.github.io/vanillajs-datepicker/#/?id=other-frameworks and https://mymth.github.io/vanillajs-datepicker/#/?id=bootstrap. It may be even better if you also check what Bulma's and Foundation's button classes are. You'll probably be able to have better understanding why you need to do it yourself via JS.

As stated in README, this library is made neither dedicated to nor primarily for Bootstrap. And I have no intention of hard-coding something specific to a particular framework into the JS programs.