mynodebtc / mynode

The easiest way to run Bitcoin and Lightning!
Other
650 stars 148 forks source link

Ability to manage macaroons through the UI #765

Open secondl1ght opened 1 year ago

secondl1ght commented 1 year ago

Is your content request related to a problem? Please describe. It would be great if you could delete, create, manage macaroons with myNode.

Describe the solution you'd like A simple UI for interacting with these LND API endpoints.

Additional context I tried doing this from the terminal but ran into some issues with lncli which I am assuming is because myNode might use a non-standard config. If adding these elements to the UI is not an option, at least some documentation on anything different with the myNode setup would be helpful so that the lncli can be used easily from the command line.

https://docs.lightning.engineering/lightning-network-tools/lnd/macaroons

tehelsper commented 1 year ago

The lncli should work fine for managing macaroons. Was there a specific error you saw?

I don't really want to add it to the UI since I'm afraid many users would accidentally shoot themselves in the foot and the option to download the admin / readonly macaroons is available and meets nearly all normal uses.

secondl1ght commented 1 year ago

My use case is that if you think your macaroon has been exposed you need to delete and create a new one.

I am fine doing this via command line but others might not be. I understand the concern though about making sensitive commands available in the UI though which could lead to more customer support tickets.

Here are the commands that I tried and the responses I got back, first I am just trying to list my macaroons before deleting and creating a new one:

admin@myNode:~ $ lnd listmacaroonids
failed to load config: ValidateConfig: either bitcoin.active or litecoin.active must be set to 1 (true)
admin@myNode:~ $ lncli listmacaroonids
[lncli] rpc error: code = Unknown desc = permission denied
admin@myNode:~ $ sudo lncli listmacaroonids
[sudo] password for admin: 
[lncli] could not load global options: could not load TLS cert file: open /root/.lnd/tls.cert: no such file or directory

Thanks

tehelsper commented 1 year ago

You may need to regen your macroons. The second command should work and this issue had a similar possible root cause. https://github.com/mynodebtc/mynode/issues/763