search

myorangedragon / longmynd

An Open Source Linux ATV receiver
GNU General Public License v3.0
25 stars 16 forks source link

TS discontinuities #22

Closed daniestevez closed 8 months ago

daniestevez commented 3 years ago

I'm watching the AMSAT-DL symposium on QO-100 today by streaming from longmynd to vlc (2Msym DVB-S2 QPSK 4/5). With the master revision I've found lots of TS discontinuities and other problems in vlc. This doesn't happen with older versions of longmynd. Using git bisect I've located the first bad commit to be 96dfaf9be7b8dab148b977c150f241e596f515c3. I'll look at this further after the conference, but I'm submitting the issue now so that I don't forget.

This also happens with the 1.5Msym beacon, so it is easy to replicate for me.

I see that #20 is very similar to this problem, but for me the current master doesn't work.

daniestevez commented 3 years ago

I now see that #21, which is the PR fixing for #20, was never merged to master. I confirm that applying the diff in #21 by hand on top of master fixes this problem, so I believe that #21 should be merge to master.

philcrump commented 3 years ago

Hi, FYI we've got a more actively maintained branch of longmynd with this and a few other fixes at https://github.com/BritishAmateurTelevisionClub/longmynd/ (this is the version used in the BATC Portsdown & Ryde projects)

daniestevez commented 3 years ago

Thanks! I didn't know about the BATC fork. I confirm that the master in there works fine for me.

philcrump commented 3 years ago

Of course when I cleaned out all my old branches from my fork it had the unintended (and un-notified) effect of closing out the pending PRs here... I'll fix that as we've never intended not to upstream it all.

BTW will be testing some new longmynd changes by watching your AMSAT-DL talk later!

daniestevez commented 8 months ago

Closing, since the BATC fork works. I probably forgot to close this back in the day.