myoung34 / docker-github-actions-runner

This will run the new self-hosted github actions runners with docker-in-docker
GNU General Public License v3.0
1.7k stars 397 forks source link

Creating github org runners #412

Open dzenansoftic opened 2 weeks ago

dzenansoftic commented 2 weeks ago

Hey, we are using this image to create github runner with keda per repo. We also want to create github org runners with keda, but with an GitHub App to increase the API rate limit. I read the dokumentation and the env variables description and have some questions.

If I understand correctly, if you try using a GitHub App you need to add APP_ID and APP_PRIVATE_KEY instead of ACCESS_TOKEN. Also the RUNNER_SCOPE should be 'org', know here is the part i dont understand completly. The description says that when RUNNER_SCOPE is set to 'org' or 'ent' ACCESS_TOKEN should be used. My understanding is know, that creating an org github runner is not possible. Is that the case or am i missing something.

Thanks a lot in advance 😊 Dzenan

myoung34 commented 2 weeks ago

I believe you can in fact use a github runner in an org as an app, but I do not have capacity to test that. If you can or others can confirm I can update the documentation to reflect

dzenansoftic commented 2 weeks ago

I will try and let you know.

A different question, is the azure-cli installed on the runner image?

myoung34 commented 2 weeks ago

All software is listed here

dzenansoftic commented 1 week ago

It is possible to create an org runner. Just use APP_ID and APP_PRIVATE_KEY instead of ACCESS_TOKEN

tudor-pop commented 1 week ago

I'm trying to deploy this as well.

          ORG_NAME=some-name
          APP_LOGIN=some-name
          APP_ID="{{ APP_ID }}"
          APP_PRIVATE_KEY='{{ PRIVATE_KEY }}'

and all I get is

Invalid configuration provided for token. Terminating unattended configuration.
An error occurred: Not configured. Run config.(sh/cmd) to configure the runner.
Runner reusage is disabled
Obtaining access token for app_id SOME_ID and login COMP_NAME
Obtaining the token of the runner
curl: (22) The requested URL returned error: 403 
Disable auto update option is enabled
Configuring

however running this from my local environment works fine and I get a token in the form of ghs_SjDicIPkx8idG...