search

myoung34 / vagrant-ovirt4

oVirt v4 provider for Vagrant
MIT License
36 stars 23 forks source link

Fix network lookup #74

Closed phoracek closed 7 years ago

phoracek commented 7 years ago

Now it works for me on master.

phoracek commented 7 years ago

I don't usually use Ruby or oVirt SDK, tell me if there is a more elegant way how to get network that is available in given cluster.

myoung34 commented 7 years ago

First: Thanks for the PR! Second: some of this I fixed yesterday in my efforts to fix my issues with DNS. Does everything work for you based on the latest master? I added some additional checks to distinguish network not found vs network not provided (it's required). Third: Depending on how comfortable you are with git, can you rebase against master to get rid of the conflicts but also merge your two commits into one? (my personal preference is a single commit per "issue" per PR - makes it easier to know what commits to pull out if something causes issues)

phoracek commented 7 years ago

I will rebase in a moment :)

phoracek commented 7 years ago

I pushed the code with your proposed change. It works for me, but I hate the infinite line, don't know how to make it multi-line though.

myoung34 commented 7 years ago