search

myoung34 / vagrant-ovirt4

oVirt v4 provider for Vagrant
MIT License
36 stars 23 forks source link

Add filtered_api config parameter #93

Closed zuc closed 6 years ago

zuc commented 7 years ago

Closes #59. This allows adding Filter: true http header to each oVirt API call (needed for non-admin users).

Sample usage in Vagrantfile:

ovirt.filtered_api = true
thomashaw commented 7 years ago

Thank you!

selurvedu commented 6 years ago

@myoung34, bump?

myoung34 commented 6 years ago

Sorry @thomashaw @selurvedu @mzuccala I'm still here, Just been very busy with other stuff and neglectful. Ill take a look tonight!

ikelos commented 6 years ago

HIya, I had to modify the patch a little, but got it applied and it solved the operation failed error I was getting.

myoung34 commented 6 years ago

@ikelos do you have that patch handy?

ikelos commented 6 years ago

I'm afraid I don't (I can get it on Monday) but it's just applying this patch with fuzzing and a little bit of human eye-work to get it to sit nicely. The only reason this didn't apply cleanly is because I had an older version of vagrant-ovirt4 installed. This patch applies to master fine. The travis failure is because the travis file doesn't install vagrant-1.1.0 (but uses vagrant-1.0.2 instead) which doesn't satisfy the requirements. The patch itself seems to work just fine (and solved the issue of getting not authorized messages when not authenticating as an admin)...

dwest-galois commented 6 years ago

The _"filteredapi" option works great. However, it does not seem to be available in the upstream ruby gem (rubygems.org). The same is true for the _"optimizedfor" option. The version on rubygems.org says it is vagrant-ovirt4 (1.2.2), while the one I built from the master branch reports that it is vagrant-ovirt4 (1.2.1, global). I am assuming the tags just aren't updated in the repo? Either way, would you be willing to push the gem up to rubygems.org to make this more widely available?

https://rubygems.org/gems/vagrant-ovirt4