mypaint / libmypaint

libmypaint, a.k.a. "brushlib", is a library for making brushstrokes which is used by MyPaint and other projects.
http://mypaint.org
Other
307 stars 87 forks source link

Brush engine cleanup #161

Closed jplloyd closed 4 years ago

jplloyd commented 4 years ago

This is primarily an effort to make the code in mypaint-brush.c more readable. It does the following:

Some of the commits could be squashed, but I think it's better to have a decent granularity for changes like these. If a bug was introduced, it's usually a lot nicer to face a +50, -62 diff at the end of a bisect, rather than one that is +462, -498.

jplloyd commented 4 years ago

@briend Unless you think that switching the FLIP state once for each prepare_and_draw_dab is incorrect (or have any other issues with these changes), I'm probably merging this tomorrow evening (CET, so in 24 hours).

briend commented 4 years ago

Gave it a spin, looks good to me! Thanks @jplloyd !