search

myparcelnl / delivery-options

Allows customers to select MyParcel delivery options from your frontend.
https://myparcel.nl
1 stars 1 forks source link

fix(pickup): fix map not mounting again after having been unmounted #239

Closed FreekVR closed 3 weeks ago

FreekVR commented 1 month ago

Fixes an issue where the map would not work again after removal.

Updates the usePickupLocationsMap-composable to use a global state where possible and not use memoization to achieve the same.

Additionally fixes an issue where the map could be panned before being fully loaded.

Fixes: INT-641

netlify[bot] commented 1 month ago

Deploy Preview for myparcel-delivery-options ready!

Name Link
Latest commit a41b9bab481cef927665d9cbecc95f17e8a3f097
Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/66e8746b2894850008439b54
Deploy Preview https://deploy-preview-239--myparcel-delivery-options.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 month ago

Bundle Report

Changes will increase total bundle size by 171 bytes (0.06%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | @myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm | 151.7kB | 81 bytes :arrow_up: | | @myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd | 116.94kB | 90 bytes :arrow_up: |
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (8285c78) to head (d3a51b1).

Files with missing lines Patch % Lines
...y-options/src/composables/usePickupLocationsMap.ts 44.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #239 +/- ## ========================================== + Coverage 74.36% 74.47% +0.10% ========================================== Files 341 341 Lines 7326 7330 +4 Branches 605 605 ========================================== + Hits 5448 5459 +11 + Misses 1281 1274 -7 Partials 597 597 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

myparcel-bot[bot] commented 3 weeks ago

:tada: This issue has been resolved in version @myparcel/delivery-options-v6.2.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: