search

myparcelnl / pdk

MyParcel Plugin Development Kit
0 stars 0 forks source link

fix(orders): fix notice when billing address or recipient are not present #237

Closed EdieLemoine closed 8 months ago

EdieLemoine commented 8 months ago

Example:

"Notice: Indirect modification of overloaded property MyParcelNL\\Pdk\\Shipment\\Model\\Shipment::$recipient has no effect"
codecov[bot] commented 8 months ago

Codecov Report

Merging #237 (8ffef2e) into main (965c6d7) will increase coverage by 0.00%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #237   +/-   ##
=========================================
  Coverage     95.55%   95.56%           
- Complexity     1577     1578    +1     
=========================================
  Files           303      303           
  Lines          5405     5409    +4     
=========================================
+ Hits           5165     5169    +4     
  Misses          240      240
Files Coverage Δ
...lculator/General/CustomerInformationCalculator.php 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

MyParcelBot commented 8 months ago

:tada: This PR is included in version 2.30.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: