search

myparcelnl / pdk

MyParcel Plugin Development Kit
0 stars 0 forks source link

fix: fix max insurance setting not being enforced #283

Closed GravendeelJochem closed 3 weeks ago

GravendeelJochem commented 1 month ago

INT-531

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (2a80eca) to head (435994b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #283 +/- ## ============================================ - Coverage 96.19% 96.19% -0.01% Complexity 1636 1636 ============================================ Files 307 307 Lines 5439 5438 -1 ============================================ - Hits 5232 5231 -1 Misses 207 207 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GravendeelJochem commented 3 weeks ago
  • Vanwege de verwarring zou ik in de tests de bedragen die achter het euro teken staan daadwerkelijk in euro’s noemen, voor de leesbaarheid.
  • Klopt deze story nu met de werking van de keuzes, cq zijn de keuzes die gemaakt (kunnen) worden nu al in centen?
  • Graag in de titel beschrijven (in gebiedende wijs) welk probleem je opgelost hebt.
myparcel-bot[bot] commented 3 weeks ago

:tada: This PR is included in version 2.39.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: