myparcelnl / prestashop

PrestaShop module to integrate with MyParcel NL and BE
https://developer.myparcel.nl/nl/documentatie/11.prestashop.html
10 stars 5 forks source link

Package type is not exported correctly #186

Closed Xesau closed 2 years ago

Xesau commented 2 years ago

Module version

1.7.0

PrestaShop version

1.7.8.6

PHP version

7.4

What went wrong?

When creating a label for a Mailbox package, it is exported as regular parcel instead.

Reproduction steps

  1. Navigate to Orders
  2. Create a package and set it to Mailbox package
  3. Click Export
  4. Check the backoffice. The package type is shown a normal parcel.

Relevant log output

No response

Additional context

No response

Xesau commented 2 years ago

It seems to be a problem with the frontend JS. The the selected value for the package type option is not correctly passed to the ajax request body. Instead it just says package type package.

Image

Xesau commented 2 years ago

When can we expect the next release?

tajriba commented 2 years ago

Does #187 also fix the empty white box when select parcel type?

We need a new release with fixes asap for our client?

EdieLemoine commented 2 years ago

The next release has been thoroughly tested, but we've found new issues with exporting return shipments. This needs to be resolved first. We hope to put out a new release next week.

@tajriba this commit is what will fix the package type select box.

tajriba commented 2 years ago

@EdieLemoine thank you. We have used 1.7.0 and the bug was still there. Also I see no file called PackageTypeSelectFormGroup.vue with the commit in 1.7.0 ? But we will wait for the next release next week and try again.thanks

EdieLemoine commented 2 years ago

We've discovered these returns issues are not new, they're not caused by the changes we want to release. So I'll publish the new release right now and returns will be fixed later. :)

MyParcelBot commented 2 years ago

:tada: This issue has been resolved in version 1.7.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: