myparcelnl / prestashop

PrestaShop module to integrate with MyParcel NL and BE
https://developer.myparcel.nl/nl/documentatie/11.prestashop.html
10 stars 5 forks source link

fix(products): improve handling of nonexistent products #229

Closed EdieLemoine closed 9 months ago

EdieLemoine commented 9 months ago

Resolves #228

INT-267

codecov[bot] commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (349fbd6) 63.70% compared to head (ca8250a) 63.74%.

Files Patch % Lines
src/Pdk/Order/Repository/PsPdkOrderRepository.php 52.94% 8 Missing :warning:
.../Pdk/Product/Repository/PsPdkProductRepository.php 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #229 +/- ## ============================================ + Coverage 63.70% 63.74% +0.03% - Complexity 617 619 +2 ============================================ Files 101 102 +1 Lines 2590 2601 +11 ============================================ + Hits 1650 1658 +8 - Misses 940 943 +3 ``` | [Flag](https://app.codecov.io/gh/myparcelnl/prestashop/pull/229/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/myparcelnl/prestashop/pull/229/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `63.74% <65.51%> (+0.03%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/myparcelnl/prestashop/pull/229/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `63.74% <65.51%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

myparcel-bot[bot] commented 5 months ago

:tada: This PR is included in version 2.0.0-beta.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: