search

myparcelnl / prestashop

PrestaShop module to integrate with MyParcel NL and BE
https://developer.myparcel.nl/nl/documentatie/11.prestashop.html
10 stars 5 forks source link

fix: fix namespace error when installing module #246

Closed EdieLemoine closed 4 months ago

EdieLemoine commented 4 months ago

INT-459

Resolves #242

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.05%. Comparing base (c8a874b) to head (fe4b2a2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #246 +/- ## ============================================ - Coverage 43.76% 41.05% -2.72% ============================================ Files 163 160 -3 Lines 4124 3875 -249 Branches 55 55 ============================================ - Hits 1805 1591 -214 + Misses 2264 2229 -35 Partials 55 55 ``` | [Flag](https://app.codecov.io/gh/myparcelnl/prestashop/pull/246/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | Coverage Δ | | |---|---|---| | [admin](https://app.codecov.io/gh/myparcelnl/prestashop/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `0.00% <ø> (ø)` | | | [backend](https://app.codecov.io/gh/myparcelnl/prestashop/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `64.12% <ø> (-1.99%)` | :arrow_down: | | [checkout](https://app.codecov.io/gh/myparcelnl/prestashop/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `0.00% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/myparcelnl/prestashop/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `0.00% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/myparcelnl/prestashop/pull/246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl) | `41.05% <ø> (-2.72%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=myparcelnl#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

myparcel-bot[bot] commented 4 months ago

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit fe4b2a22aea1a61ffc9e55306ba09b10435d94fe
Logs https://github.com/myparcelnl/prestashop/actions/runs/8815946535
Download https://github.com/myparcelnl/prestashop/suites/23098258946/artifacts/1443788767
EdieLemoine commented 4 months ago

@mariuszsienkiewicz I added you as a co-author to my commit to give you some credit. If you're willing to test this that would be wonderful. The link to the build is conveniently provided in above comment by @MyParcelBot (the zip contains both modules, so unpack it first)

mariuszsienkiewicz commented 4 months ago

@EdieLemoine I have made the same exact changes yesterday, and the configuration page showed up without any issues. Thank you! 🫡