search

mypebble / django-pgviews

Fork of django-postgres that focuses on maintaining and improving support for Postgres SQL Views.
The Unlicense
195 stars 41 forks source link

Django 2.2+ support #56

Open mikeIFTS opened 4 years ago

mikeIFTS commented 4 years ago

References #53

Minimal changes to get this package working with Django 2.2.10+

Sample CI Build is here: https://circleci.com/gh/IFTServices/django-pgviews/11?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

benglewis commented 4 years ago

Any reading for the delay in the approval of this PR? I would very much like to use this code - but my codebase is already on Django 2.2 (and current Django is already Django 3.0). Can I help?

Mogost commented 4 years ago

https://pypi.org/project/django-pgviews-redux/

robvdl commented 4 years ago

@benglewis the issue seems to be that there are changes requested 24 days ago, so it's upto the original author @mikeIFTS of this PR to fix these and then we should see it merged I hope.

robvdl commented 4 years ago

I'm not sure if a fork is the right solution, perhaps helping on the project instead?

I do get it though, Django 1.11 LTS is out of support, getting 2.2 LTS support going should be the number one priority, nothing else really matters but to get off 1.11 LTS.

scott-w commented 4 years ago

Hey @robvdl normally I would agree, however as the original maintainer within Pebble, I'd give my blessing to a fork. Simply put, I don't work at Pebble any more and I don't know any of the devs that work there, so I can't influence anything from my end.

robvdl commented 4 years ago

Thanks @scott-w I'll have a talk with people from work on Monday. I am not currently using this but our team stumbled across it but couldn't use it due to lack of Django 2.2 support at the time so we didn't. It might be worth maintaining though, we are a company that uses Postgres a lot. I wouldn't just jump on it though, because I already maintain more than I can handle myself, know the feeling all too well.

Mogost commented 4 years ago

@scott-w, Maybe we should add some kind of record about the fork from @mikicz in the README file? To make it easier for people to find a supported fork.