search

myrao / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

odd width support #198

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
set LIBYUV_WIDTH=31
run unittests
some unittests fail.  Most likely its the unittests not allocating enough 
memory for subsampled planes.

example:
libyuvTest.ARGB1555ToI420_Opt

Original issue reported on code.google.com by fbarch...@chromium.org on 10 Mar 2013 at 4:26

GoogleCodeExporter commented 9 years ago 
Unittests are not rounding up for subsampling.
kWidth / SUBSAMP_X

Should be 
(kWidth + SUBSAMP_X - 1 ) / SUBSAMP_X

Original comment by fbarch...@chromium.org on 12 Mar 2013 at 11:43

GoogleCodeExporter commented 9 years ago 
With convert unittest fixed, these are the remaining fails:

[==========] 595 tests from 1 test case ran. (515 ms total)
[  PASSED  ] 568 tests.
[  FAILED  ] 27 tests, listed below:
[  FAILED  ] libyuvTest.I420ToBayerBGGR_Any
[  FAILED  ] libyuvTest.ARGBToBayerBGGR_Any
[  FAILED  ] libyuvTest.ARGBToBayerBGGR_Unaligned
[  FAILED  ] libyuvTest.ARGBToBayerBGGR_Invert
[  FAILED  ] libyuvTest.ARGBToBayerBGGR_Opt
[  FAILED  ] libyuvTest.ARGBToBayerRGGB_Any
[  FAILED  ] libyuvTest.ARGBToBayerRGGB_Unaligned
[  FAILED  ] libyuvTest.ARGBToBayerRGGB_Invert
[  FAILED  ] libyuvTest.ARGBToBayerRGGB_Opt
[  FAILED  ] libyuvTest.ARGBToBayerGBRG_Any
[  FAILED  ] libyuvTest.ARGBToBayerGBRG_Unaligned
[  FAILED  ] libyuvTest.ARGBToBayerGBRG_Invert
[  FAILED  ] libyuvTest.ARGBToBayerGBRG_Opt
[  FAILED  ] libyuvTest.ARGBToBayerGRBG_Any
[  FAILED  ] libyuvTest.ARGBToBayerGRBG_Unaligned
[  FAILED  ] libyuvTest.ARGBToBayerGRBG_Invert
[  FAILED  ] libyuvTest.ARGBToBayerGRBG_Opt
[  FAILED  ] libyuvTest.TransposeUV
[  FAILED  ] libyuvTest.RotateUV90
[  FAILED  ] libyuvTest.RotateUV180
[  FAILED  ] libyuvTest.RotateUV270
[  FAILED  ] libyuvTest.RotatePlane270Pitch
[  FAILED  ] libyuvTest.NV12ToI420Rotate90
[  FAILED  ] libyuvTest.NV12ToI420Rotate270
[  FAILED  ] libyuvTest.NV12ToI420Rotate180
[  FAILED  ] libyuvTest.NV12ToI420RotateNegHeight90
[  FAILED  ] libyuvTest.NV12ToI420RotateNegHeight180

27 FAILED TESTS

They fail with C code, as well as assembler.

Original comment by fbarch...@chromium.org on 13 Mar 2013 at 12:13

GoogleCodeExporter commented 9 years ago 
fixed in r602.  All issues found were in the unittests.
Bayer has odd width issue - disabled test with TODO.  Conversion appears 
correct.
SSim fails on width less than 8, but odd is okay.

Original comment by fbarch...@chromium.org on 13 Mar 2013 at 5:52