search

myrao / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

FixedDiv off by 1 #250

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Try bot fails on a windows build.
Can't reproduce locally on Windows.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] libyuvTest.TestFixedDiv_Opt

 1 FAILED TEST
@@@STEP_LOG_LINE@TestFixedDiv_Opt@libyuvTest.TestFixedDiv_Opt: @@@
@@@STEP_LOG_LINE@TestFixedDiv_Opt@unit_test\math_test.cc(69): error: Value of: 
libyuv::FixedDiv(1080 * 2, 1080)@@@
@@@STEP_LOG_LINE@TestFixedDiv_Opt@Actual: 131071@@@
@@@STEP_LOG_LINE@TestFixedDiv_Opt@Expected: 0x20000@@@
@@@STEP_LOG_LINE@TestFixedDiv_Opt@Which is: 131072@@@
@@@STEP_LOG_END@TestFixedDiv_Opt@@@
@@@STEP_WARNINGS@@@
@@@STEP_TEXT@libyuv_unittest@@@
@@@STEP_TEXT@failed 1@@@
program finished with exit code 1

Original issue reported on code.google.com by fbarch...@google.com on 17 Jun 2013 at 5:18

GoogleCodeExporter commented 9 years ago 
r729 addresses unittest with allowing off by 1.  But should followup with 
improved accuracy.

Original comment by fbarch...@google.com on 17 Jun 2013 at 5:23

GoogleCodeExporter commented 9 years ago 
Current performance with float table on
Windows
9868 - [       OK ] libyuvTest.TestFixedDiv (9868 ms)
1341 - [       OK ] libyuvTest.TestFixedDiv_Opt (1341 ms)
Linux
libyuvTest.TestFixedDiv (8223 ms)
libyuvTest.TestFixedDiv_Opt (2194 ms)

Original comment by fbarch...@google.com on 17 Jun 2013 at 10:38

GoogleCodeExporter commented 9 years ago 
Fixed in r732
Was 
libyuvTest.TestFixedDiv (9873 ms)
libyuvTest.TestFixedDiv_Opt (1349 ms)
with error of +-3

Now
libyuvTest.TestFixedDiv (6728 ms)
libyuvTest.TestFixedDiv_Opt (1999 ms)
with error of +-1

Original comment by fbarch...@google.com on 18 Jun 2013 at 4:46

GoogleCodeExporter commented 9 years ago 
[71/266] CXX obj/source/libyuv.row_common.o
../../source/row_common.cc:64:3: warning: this decimal constant is unsigned 
only in ISO C90 [enabled by default]

Original comment by fbarch...@chromium.org on 18 Jun 2013 at 5:45

GoogleCodeExporter commented 9 years ago 
Fixed in r733/734

Original comment by fbarch...@chromium.org on 18 Jun 2013 at 7:15

GoogleCodeExporter commented 9 years ago 
r736 reverts back to divide, as off by 1 caused valgrind failures.

Original comment by fbarch...@chromium.org on 18 Jun 2013 at 10:12

GoogleCodeExporter commented 9 years ago 
Reopened, as current fixed div does not build.

LINK newlib/Debug/nacltest_x86_64.nexe
newlib/Debug/source/row_common_x86_64.o: In function `FixedDiv_C':
/cygdrive/d/src/libyuv/trunk/source/row_common.cc:63: multiple definition of 
`FixedDiv_C'
newlib/Debug/source/row_posix_x86_64.o:/cygdrive/d/src/libyuv/trunk/source/row_p
osix.cc:5403: first defined here

Original comment by fbarch...@google.com on 6 Aug 2013 at 5:34

GoogleCodeExporter commented 9 years ago 
fixed in r747

Original comment by fbarch...@google.com on 7 Aug 2013 at 8:54