search

myrao / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

armv7s support for ios #316

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
follow ios build steps but target armv7s

What is the expected output?
armv7s architecture

What do you see instead?
armv7

Original issue reported on code.google.com by fbarch...@chromium.org on 12 Mar 2014 at 11:05

GoogleCodeExporter commented 9 years ago 
r991 updated chromium deps and allows the builds.

GYP_DEFINES="OS=ios target_arch=armv7s" GYP_CROSSCOMPILE=1 
GYP_GENERATOR_FLAGS="output_dir=out_ios" ./build/gyp_chromium -f ninja 
--depth=. libyuv_test.gyp 

But there are build errors:
ninja: Entering directory `out_ios/Debug-iphoneos'
[36/37] LINK compare, POSTBUILDS
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ 
-Wl,-search_paths_first -miphoneos-version-min=6.0 -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer
/SDKs/iPhoneOS7.0.sdk -arch armv7 -L. -o compare obj/util/compare.compare.o 
libyuv.a  
Undefined symbols for architecture armv7:
  "_SumSquareError_NEON", referenced from:
      _ComputeSumSquareError in libyuv.a(libyuv.compare.o)
ld: symbol(s) not found for architecture armv7
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[36/37] LINK convert, POSTBUILDS
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ 
-Wl,-search_paths_first -miphoneos-version-min=6.0 -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer
/SDKs/iPhoneOS7.0.sdk -arch armv7 -L. -o convert obj/util/convert.convert.o 
libyuv.a  
Undefined symbols for architecture armv7:
  "_ABGRToUVRow_NEON", referenced from:
      _ABGRToI420 in libyuv.a(libyuv.convert.o)
      _ABGRToUVRow_Any_NEON in libyuv.a(libyuv.row_any.o)
...

Original comment by fbarch...@chromium.org on 28 Mar 2014 at 7:43

GoogleCodeExporter commented 9 years ago 
GYP_DEFINES="OS=ios target_arch=armv7s" GYP_CROSSCOMPILE=1 
GYP_GENERATOR_FLAGS="output_dir=out_ios" ./build/gyp_chromium -f ninja 
--depth=. libyuv_test.gyp

ninja -v -C out_ios/Debug-iphoneos

still shows -arch armv7 is still used.  Seems like chrome infrastructure doesnt 
support this yet.

Original comment by fbarch...@google.com on 1 Apr 2014 at 3:44

GoogleCodeExporter commented 9 years ago 
Currently the chromium build infrastructure only supports armv7 and arm64.
I've added arm64, which is really armv8 in 64 bit mode, and includes armv7s 
instruction set.
Until this is added to chromium, its unfeasible to add to libyuv/webrtc

Original comment by fbarch...@google.com on 2 Apr 2014 at 1:09