myriadrf / libxtrxll

Low-level XTRX hardware abstraction library
Apache License 2.0
14 stars 14 forks source link

udev rules installation should be optional #1

Closed smunaut closed 6 years ago

smunaut commented 6 years ago

If you install in a non standard path ( e.g. I use -DCMAKE_INSTALL_PREFIX=/opt/xtrx ) :

chemeris commented 6 years ago

Optional = a cmake option or some other way?

smunaut commented 6 years ago

Yeah CMake option is fine. "INSTALL_UDEV_RULES" is what's used in rtl-sdr and hackrf (and others IIRC). Also the destination is always set as absolute rather than relative because the destination prefix can vary.

chemeris commented 6 years ago

I see. Could you point to an example or share a patch?

Written with a touchscreen keyboard. Please bear with typos and crazy autocorrections.

-- Regards, Alexander Chemeris. CTO/Founder, Fairwaves, Inc. https://fairwaves.co

On Sat, May 19, 2018, 16:05 smunaut notifications@github.com wrote:

Yeah CMake option is fine. "INSTALL_UDEV_RULES" is what's used in rtl-sdr and hackrf (and others IIRC). Also the destination is always set as absolute rather than relative because the destination prefix can vary.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xtrx-sdr/libxtrxll/issues/1#issuecomment-390411026, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWCgqvMLD1WnwU49k1KFczulxYTJLcBks5t0DSvgaJpZM4UFtv8 .

mnhauke commented 6 years ago

https://github.com/xtrx-sdr/libxtrxll/pull/2

chemeris commented 6 years ago

PR #2 has been merged