search

myriameayman / Raye7-

0 stars 1 forks source link

offering ride #25

Closed myriameayman closed 9 years ago

myriameayman commented 9 years ago

@AhmedAdelIbrahim , @mahatalaat , @renadshaaban , @ebrahim-elgaml , @som3a123 , @MariamTalaat plz review me

renadshaaban commented 9 years ago

@myriameayman as for UML diagram why is the user clicks on new request takes 1.x ? It should be 2

renadshaaban commented 9 years ago

@myriameayman it is okay :dancer:

mahatalaat commented 9 years ago

@myriameayman
In all the files you edited the 1st letter after the hash must be capitalized and the end of each comment must have a dot so please check them all in the controller part : Lines 35 and 36 leave space between # and 1st letter/symbol in the view part: I couldnot find any code in the gecoding and the reverse_gecoding , as for the create file line 73 its function not fumction ¨typo¨ , and line 95 leave space

AhmedAdelIbrahim commented 9 years ago

@myriameayman Done with the test review and the testing is working fine

mahatalaat commented 9 years ago

@myriameayman perfect