search

myriamlr / exposition-family

Automatically exported from code.google.com/p/exposition-family
0 stars 0 forks source link

mpGraphs is broken #53

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The col parameter is not being used correctly. Run the CSDA example and you'll 
see this after traceback():

3: prettyPlot(res$Table$partial.fi, x_axis = x_axis, y_axis = y_axis, 
       col = rep(fi.col, res$Overview$num.groups), xlab = xlab.table, 
       ylab = ylab.table, main = paste("Partial Scores", main), 
       dev.new = TRUE) at mpGraphs.R#112
2: mpGraphs(res, table = res$Overview$table, DESIGN = DESIGN, main = main, 
       graphs = graphs) at mpDISTATIS.R#58
1: mpDISTATIS(cbind(BEER.DIST, phys.dist), DESIGN = STYLES, sorting = "No", 
       normalization = "MFA", table = table)

I believe the mismatch is here:
col = rep(fi.col, res$Overview$num.groups)

fi.col should only be matrix (lots of rows, 1 column); however, I may force 
these items to be of matrix type upon entry. We need to double check.

Original issue reported on code.google.com by DerekBea...@gmail.com on 2 May 2013 at 8:23

GoogleCodeExporter commented 9 years ago 
This may be a separate error, but the point is the same: mpGraphs is a bit 
broken.

Run the CSDA example:

>table <- c(rep("flavors",ncol(BEER.DIST)),rep("meters",ncol(phys.dist))) 
>demo.distatis <- mpDISTATIS(cbind(BEER.DIST,phys.dist), DESIGN=STYLES, 
sorting='No', normalization='MFA',table=table, make.design.nominal=FALSE)

Then do this:
>mpGraphs(demo.distatis,main="Compromise of Flavor and Physical Distances")

ERROR: Error in if (!(nrow(res$fi) == nrow(mpPlotInfo$ficol)) || !(nrow(res$fj) 
==  : 
  missing value where TRUE/FALSE needed

Original comment by DerekBea...@gmail.com on 14 Aug 2013 at 5:51

GoogleCodeExporter commented 9 years ago

Original comment by DerekBea...@gmail.com on 14 Aug 2013 at 5:51