myriath / CS309-Project

1 stars 0 forks source link

Re-did the add recipe page - [merged] #69

Closed myriath closed 1 year ago

myriath commented 2 years ago

In GitLab by @tmassner927 on Oct 21, 2022, 10:09

Merges 29-recipe-add-fix -> frontend-dev

I added a bit more functionality with the add recipe page

myriath commented 2 years ago

In GitLab by @tmassner927 on Oct 21, 2022, 10:09

requested review from @myriath

myriath commented 2 years ago

Maybe using a string array would work better? That way each step can displayed on its own line

myriath commented 2 years ago

There is a null id constant in Constants that you should probably use instead

myriath commented 2 years ago

In GitLab by @tmassner927 on Nov 2, 2022, 03:25

Commented on Frontend/app/src/main/java/com/example/cs309android/models/gson/models/SimpleRecipeItem.java line 61

Got it done

myriath commented 2 years ago

In GitLab by @tmassner927 on Nov 2, 2022, 03:27

Commented on Frontend/app/src/main/java/com/example/cs309android/models/gson/models/SimpleRecipeItem.java line 31

Yes, that would be a good idea. Although for now, I am going to hold off until I get some of the other core features finished before doing that.

myriath commented 2 years ago

In GitLab by @tmassner927 on Nov 2, 2022, 03:30

Commented on Frontend/app/src/main/java/com/example/cs309android/models/gson/models/SimpleRecipeItem.java line 61

changed this line in version 2 of the diff

myriath commented 2 years ago

In GitLab by @tmassner927 on Nov 2, 2022, 03:30

added 1 commit

Compare with previous version

myriath commented 2 years ago

resolved all threads

myriath commented 2 years ago

approved this merge request