myrilla12 / pe

0 stars 0 forks source link

Duplicate phone numbers permitted #6

Open myrilla12 opened 1 week ago

myrilla12 commented 1 week ago

Details

More than one employee is permitted to have the same phone number. Screenshot 2024-11-15 at 5.11.16 PM.png

In the context of the application, this is not possible.

Suggested improvement

Improve data validation by avoiding duplicate phone numbers.

nus-se-bot commented 1 week ago

Team's Response

Thanks for bringing this to our attention.

While it is true that in most cases phone numbers are unique, we feel it is different in our use case.

image.png

As mentioned above in our User Guide, we take into account that different employees may be contacted by the same phone number (e.g. if the whole department shares one professional phone number). Therefore, this feature is intentional and is (we feel) relevant to our application.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]