myrne / performance-now

Implements performance.now (based on process.hrtime).
MIT License
162 stars 26 forks source link

Dist code in `lib` directory contains a src map link. #4

Closed glan closed 10 years ago

glan commented 10 years ago

I'm not sure if you would class this as a bug, however I'm building a project which uses performance-now via raf and rome. I'm using gulp-browserify with debug: true (source maps enabled). The problem is that the source maps stop working when the following lines are included in ./lib/performance-now.js.

/*
//@ sourceMappingURL=performance-now.map
*/

I'm just wondering if the shipping lib build could skip src maps, which could be reserved for dev builds?

myrne commented 10 years ago

I think it's actually an issue with either browserify or how gulp-browserify uses it, but I think here the pragmatic choice is to just leave the source map out. It's such little code after all. I probably look into what's really causing this issue later.

The new code without source map is published as v0.2.0. Enjoy. :)