search

myroslavarm / Experimental-Completion

My internship project: improving code completion for Pharo
6 stars 3 forks source link

Pharo8 : improve code completion for temps #49

Closed myroslavarm closed 5 years ago

myroslavarm commented 5 years ago

when declaring temps, they get completed. they shouldn't because we are essentially making up new variables

MarcusDenker commented 5 years ago

is this still a problem in Pharo8? When I tried it did not complete them anymore

MarcusDenker commented 5 years ago

double check: the old completion wants to complete temp var declarations, the new one does not.

Which I think is better.

myroslavarm commented 5 years ago

update : test completion works well new model should be fixed

myroslavarm commented 5 years ago

should be fixed in : https://github.com/myroslavarm/Experimental-Completion/commit/b1e5b306fb54a4838c245a3463b0056c92f6fa98. the problem was that because of caching method suggestions and interpreting temp declaration as part of the method, the only suggestion for temps was the name of the class it's in. i have now changed it to no completion, because a) it was totally incorrect b) temp declaration should not be completed

MarcusDenker commented 5 years ago

It is now disabled, but it might be interesting later to find a way to suggest something |forThis |

(future work)

MarcusDenker commented 5 years ago

this is fixed

myroslavarm commented 5 years ago

FINALLY fixed in this commit : https://github.com/pharo-project/pharo/pull/4062/commits/ddc49cdf2ae398da1e2711cecde3625c4ba0e4a8. temps don't get completed but methods do, and everything works! again, the problem was with error node