search

myroslavarm / Experimental-Completion

My internship project: improving code completion for Pharo
6 stars 3 forks source link

add method definition competion #60

Closed myroslavarm closed 5 years ago

myroslavarm commented 5 years ago

the line (self methodNames includes: aRBMethodNode) ifFalse: [ ^#() ]. in MatchedNodeProducer >> visitMethodNode: aRBMethodNode gets rid of the incorrect temp definition completion, but also stops method definitions from being completed. we need to figure out a way to fix it

MarcusDenker commented 5 years ago

This is closed: method definitions are now completed. The workaround stays for not completing temp definitions, which does not work yet

myroslavarm commented 5 years ago

reopened because while the workaround exists method definitions are not completed :(

myroslavarm commented 5 years ago

fixed in this commit : https://github.com/pharo-project/pharo/pull/4062/commits/ddc49cdf2ae398da1e2711cecde3625c4ba0e4a8